use go 1.26#128
Conversation
1.24 is out of support
blgm
left a comment
blgm
left a comment
There was a problem hiding this comment.
LGTM
Just a note that you don't have to update the Go directive just because the version mentioned is out of support. As long as the Go compiler is in support, then everything should work in a backwards-compatible way.
Having said this, I like updating the Go directive as it prevents accidentally using an old compiler, and opts in to new features.
I did remember this, though we've also configured the github action release and ci use the go version from the file. So seems worth keeping that up to date so that the github action uses a reasonable version of go. Rather mange the go version in one place rather than all three while making sure our tests/ci system use a supported go version |
3 participants
1.24 is out of support